Skip to content

WIP - Plug in Project Settings Page UI with API #4924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

WIP - Plug in Project Settings Page UI with API #4924

wants to merge 1 commit into from
+148 −22

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 4, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on enhancing the project settings functionality within the dashboard. It introduces a new updateProject function for updating project details via an API call and modifies the settings page to utilize this function, improving user experience and project management.

Detailed summary

  • Added updateProject function for updating project details via API.
  • Updated page.tsx to fetch teamId and pass it to the settings component.
  • Modified ProjectGeneralSettingsPageForTeams to accept a Project object instead of project_slug.
  • Introduced ProjectNameSetting component for updating project names.
  • Implemented error handling and user feedback for project name updates.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 04dcfdf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 5:58pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 4, 2024 5:58pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 4, 2024 5:58pm
wallet-ui ⬜️ Skipped (Inspect) Oct 4, 2024 5:58pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 4, 2024 16:42 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 4, 2024 16:42 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 4, 2024 16:42 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 4, 2024
@MananTank MananTank marked this pull request as ready for review October 4, 2024 16:43
This was referenced Oct 4, 2024
Merged
Merged
@MananTank Graphite App
Copy link
Member Author

MananTank commented Oct 4, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 4, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codecov
Copy link

codecov bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.61%. Comparing base (b148fa0) to head (04dcfdf).
Report is 297 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4924   +/-   ##
=======================================
  Coverage   47.61%   47.61%           
=======================================
  Files        1057     1057           
  Lines       57224    57224           
  Branches     3924     3924           
=======================================
  Hits        27247    27247           
  Misses      29288    29288           
  Partials      689      689
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from b148fa0
packages 43.37% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.96 KB (0%) 840 ms (0%) 343 ms (+48.63% 🔺) 1.2 s
thirdweb (cjs) 101.68 KB (0%) 2.1 s (0%) 593 ms (-23.09% 🔽) 2.7 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 92 ms (+422.98% 🔺) 188 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 26 ms (+203.99% 🔺) 36 ms
thirdweb/react (minimal + tree-shaking) 17.23 KB (0%) 345 ms (0%) 149 ms (+235.05% 🔺) 494 ms

@MananTank MananTank marked this pull request as draft October 4, 2024 17:36
@MananTank MananTank changed the base branch from 10-02-plug_in_team_settings_page_ui_to_api to graphite-base/4924 October 4, 2024 17:36
@MananTank MananTank force-pushed the 10-04-wip_-_plug_in_project_settings_page_ui_with_api branch from 799dfcb to f18b779 Compare October 4, 2024 17:48
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 4, 2024 17:48 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 4, 2024 17:48 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 4, 2024 17:48 Inactive
@MananTank MananTank changed the base branch from graphite-base/4924 to main October 4, 2024 17:48
@MananTank MananTank force-pushed the 10-04-wip_-_plug_in_project_settings_page_ui_with_api branch from f18b779 to 04dcfdf Compare October 4, 2024 17:48
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 4, 2024 17:48 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 4, 2024 17:48 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 4, 2024 17:48 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

This PR has been inactive for 30 days. It is now marked as stale and will be closed in 5 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Nov 4, 2024
@MananTank MananTank closed this Nov 4, 2024
@MananTank MananTank deleted the 10-04-wip_-_plug_in_project_settings_page_ui_with_api branch December 18, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls Awaiting requested review from jnsdls

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard. Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MananTank